Scopes break when binding events to a component #16

Closed
opened 2021-10-08 19:52:35 +00:00 by ccampbell · 8 comments
ccampbell commented 2021-10-08 19:52:35 +00:00 (Migrated from github.com)

I just started noticing this recently and tested in safe mode in Sublime Text 4. You can see here:

Please let me know if you need any more information. It looks like it starts with the first closing bracket } which is scoped as invalid.illegal.stray-bracket-end.js

I am happy to take a look at fixing it myself too, but figured I would open up an issue here since you may know exactly what the issue is. Thanks!

I just started noticing this recently and tested in safe mode in Sublime Text 4. You can see here: <img src="https://user-images.githubusercontent.com/259316/136616992-cf4367c0-a9df-4fb8-8d14-d0f9cea2c664.png" width="605" height="93" /> Please let me know if you need any more information. It looks like it starts with the first closing bracket `}` which is scoped as `invalid.illegal.stray-bracket-end.js` I am happy to take a look at fixing it myself too, but figured I would open up an issue here since you may know exactly what the issue is. Thanks!
easyfrog commented 2021-10-26 11:03:42 +00:00 (Migrated from github.com)

I have same issue, could you tell me how you fix it?

I have same issue, could you tell me how you fix it?
ilokhov commented 2021-10-26 16:19:01 +00:00 (Migrated from github.com)

Seeing the same issue, specifically after updating Sublime Text to Build 4121. The change to cause this might have happened in dev Build 4114 which mentions "Various syntax highlighting improvements" in the changelog.

Seeing the same issue, specifically after updating Sublime Text to Build 4121. The change to cause this might have happened in [dev Build 4114 which mentions "Various syntax highlighting improvements" in the changelog](https://www.sublimetext.com/dev).
ccampbell commented 2021-10-26 17:30:03 +00:00 (Migrated from github.com)

I actually have a fix for this. Will try to clean it up and send a PR later today.

I actually have a fix for this. Will try to clean it up and send a PR later today.
wmstens commented 2021-10-29 02:03:22 +00:00 (Migrated from github.com)

It sounds like the original dev is busy. Do you have the fix ironed out @ccampbell? Sorry to bug.

It sounds like the original dev is busy. Do you have the fix ironed out @ccampbell? Sorry to bug.
ccampbell commented 2021-10-29 05:17:54 +00:00 (Migrated from github.com)

@wmstens just opened a pull request. Feel free to try out my fork. #18

@wmstens just opened a pull request. Feel free to try out my fork. #18
wmstens commented 2021-10-30 00:08:29 +00:00 (Migrated from github.com)

I just sideloaded this fork and it seems to work for me. Thanks a bunch!

I just sideloaded this fork and it seems to work for me. Thanks a bunch!
corneliusio commented 2021-10-30 15:45:22 +00:00 (Migrated from github.com)

Noting here, I've started working on some fixes that are in the https://github.com/corneliusio/svelte-sublime/tree/v4 branch. There are still some issues, but it's far less broken than the current release. Feel free to manually install while I finish up some of the smaller fixes.

I'm also going to lock convo on this issue in favor of #17 to tidy things up a bit, will leave this open till resolved though for reference.

Noting here, I've started working on some fixes that are in the https://github.com/corneliusio/svelte-sublime/tree/v4 branch. There are still some issues, but it's far less broken than the current release. Feel free to manually install while I finish up some of the smaller fixes. I'm also going to lock convo on this issue in favor of #17 to tidy things up a bit, will leave this open till resolved though for reference.
corneliusio commented 2021-10-30 16:48:01 +00:00 (Migrated from github.com)

Should now be fixed with v3.5.0.

Should now be fixed with v3.5.0.
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
repos/svelte-sublime#16
No description provided.